docker: Add VS_COMMONS_DIR, set bash as default shell #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to KaruroChori#47 This sets the default shell for 'builder' to '/bin/bash'. When using 'meson devenv', the prompt becomes "[vs-fltk] builder@0884a9be3841:/vs-workspace/build$" instead of "?" now. Although that doesn't really improve anything except cli editing, as I've moved the variables to the entrypoint scripts, and therefore devenv isn't needed if using the docker container. This also fixes this annoying message when starting the container: bash: cannot set terminal process group (14): Inappropriate ioctl for device bash: no job control in this shell builder@b7d17feb7490:~$
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #47
This sets the default shell for 'builder' to '/bin/bash'.
When using 'meson devenv', the prompt becomes "[vs-fltk] builder@0884a9be3841:/vs-workspace/build$" instead of "?" now.
Although that doesn't really improve anything except cli editing, as I've moved the variables to the entrypoint scripts, and therefore devenv isn't needed if using the docker container.
This also fixes this annoying message when starting the container:
bash: cannot set terminal process group (14): Inappropriate ioctl for device
bash: no job control in this shell
builder@b7d17feb7490:~$