Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace contents of itoa() with snprintf() #52

Closed
wants to merge 1 commit into from

Conversation

andy5995
Copy link
Contributor

@andy5995 andy5995 commented Dec 9, 2024

I wanted to ask if you want a change like this? I know it needs more work though, but I wanted to check with you before continuing.

@andy5995 andy5995 marked this pull request as draft December 9, 2024 08:33
@KaruroChori
Copy link
Owner

KaruroChori commented Dec 9, 2024

It cannot accept it because:

Still, I am very positive about moving the implementation out of tcc into the main compiled application

  • to make scripts faster & lighter
  • because that code would be much better optimized by clang

Aside from that, at some point there should be some discussion on which features to expose to the C scripts beyond the specific functions/macros defined by vs. That fragment of libc is for the most part just a placeholder to have something functional, but we can decide to have a different runtime.

@andy5995 andy5995 closed this Dec 9, 2024
@andy5995
Copy link
Contributor Author

andy5995 commented Dec 9, 2024

@KaruroChori It's my understanding that the base wouldn't be needed if using snprintf().

As for the other things, I'm happy to close this. :)

@andy5995 andy5995 deleted the refactor/itoa branch December 11, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants