-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default build script, minor docker fixes #57
Add default build script, minor docker fixes #57
Conversation
2fb57c1
to
4868b0b
Compare
a9aa1f0
to
a8fb063
Compare
@KaruroChori This is ready for review. |
Hey, thanks! It also cleaned up the yml file quite a bit. |
One problem with that script is that it takes longer because it reconfigures each time. I opened a related issue for that: #59 |
There is a second problem I have been thinking. Meson subprojects should be probably updated at some point? |
Hmmm... locally yes. That could be added to this build script for now, and see how we like it, change later if necessary. Could add a check so it doesn't bother to run if it's in the CI. We could add a prompt to the script, so the user can just hit y or n to run it. Maybe a timeout.. I think that can be done with 'read' ChatGPT says yes, and I think I've experimented with that before: #!/bin/bash
read -t 4 -p "Do you want to proceed? (yes/no) " answer
# Check if input was received within 4 seconds
if [ $? -ne 0 ]; then
echo "Timed out. Defaulting to 'no'."
answer="no"
fi
# Normalize input (convert to lowercase) and handle response
case "${answer,,}" in
yes)
echo "You chose yes."
;;
no)
echo "You chose no."
;;
*)
echo "Invalid input. Defaulting to 'no'."
;;
esac |
* WORKSPACE did not get set correctly because it was doublequoted * Set vars in yml
a8fb063
to
a3d1125
Compare
e5e5359
to
a0e8aaa
Compare
fi | ||
|
||
set -v | ||
if [ "CI" != "true" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this section to update subprojects as a separate commit. Let me know if you hate it and I'll revert it. ;) I liked this idea better than the prompt w/timeout.
Co-authored-by: Andy Alt <[email protected]>
Thank you! |
These commits should not necessarily be squashed when merging. Your call.
The PR title could be changed though.
The changes here I think are fairly self-explanatory, with some details in the first commit. It'll probably make more sense if you first look at the two commits separately, rather than from the "files changed" tab.