-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test brew fltk #67
Test brew fltk #67
Conversation
…the new supported properties
7aa672b
to
27e7f13
Compare
Somehow, while installing and detecting fltk on the system, it fall back to the custom compiled version, and even worse it forces X11. This might actually be related to #42. |
Would using '--wrap-mode nofallback' help? https://github.com/theimpossibleastronaut/rmw/blob/cc3f7bc1cd4dcb427ef3dcea90a7de7454974eb1/.github/workflows/c-cpp.yml#L141C26-L141C48 |
I don't see anywhere in the meson.build where it looks for an installed fltk. I think you need something like this:
|
libfltk_forms_dep = dependency('fltk-images', version : '>=1.4', required: false) | ||
if libfltk_dep.found()==false or libfltk_images_dep.found()==false or libfltk_forms_dep.found()==false | ||
need_fltk=true | ||
libfltk_dep = dependency('fltk', version: '>=1.4', required: false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see here you've added the check for installed fltk...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, in theory I implemented some logic to search for the system default with a compatible version (unless forced not to). Else it uses the one provided via wrap.
All of this, in theory.
Just for CI