Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test brew fltk #67

Closed
wants to merge 8 commits into from
Closed

Test brew fltk #67

wants to merge 8 commits into from

Conversation

KaruroChori
Copy link
Owner

Just for CI

@KaruroChori
Copy link
Owner Author

Somehow, while installing and detecting fltk on the system, it fall back to the custom compiled version, and even worse it forces X11. This might actually be related to #42.

@andy5995
Copy link
Contributor

@andy5995
Copy link
Contributor

Somehow, while installing and detecting fltk on the system, it fall back to the custom compiled version, and even worse it forces X11. This might actually be related to #42.

I don't see anywhere in the meson.build where it looks for an installed fltk. I think you need something like this:

sqlitecpp_dep = dependency('sqlitecpp', required: false)
if not sqlitecpp_dep.found()
    sqlitecpp_dep = cxx.find_library('SQLiteCpp', required: false)
    if not sqlitecpp_dep.found()
        sqlitecpp_dep = dependency(
            'sqlitecpp',
            fallback: ['sqlitecpp', 'sqlitecpp_dep'],
            default_options: 'default_library=static',
        )
    endif
endif

sqlite_dep = dependency(
    'sqlite3',
    version: '>=3.0.0',
    fallback: ['sqlite3', 'sqlite3_dep'],
    default_options: 'default_library=static',
)

libfltk_forms_dep = dependency('fltk-images', version : '>=1.4', required: false)
if libfltk_dep.found()==false or libfltk_images_dep.found()==false or libfltk_forms_dep.found()==false
need_fltk=true
libfltk_dep = dependency('fltk', version: '>=1.4', required: false)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see here you've added the check for installed fltk...

Copy link
Owner Author

@KaruroChori KaruroChori Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, in theory I implemented some logic to search for the system default with a compatible version (unless forced not to). Else it uses the one provided via wrap.

All of this, in theory.

@KaruroChori KaruroChori deleted the test-brew-fltk branch December 16, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants