Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding MNIST example #59

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Conversation

a-vartenkov
Copy link
Collaborator

No description provided.

}
result.data_.wta_data[i].first.push_back(population_uids[INPUT]);

// В сеть добавлены все нужные популяции, теперь связываем их проекциями. Пусть последовательно.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Комменты а русском.

Copy link
Contributor

@artiomn artiomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Надо влить сюда мастер, убрать русские комменты и нормально отформатировать (включи прекоммит у себя).

constexpr float base_resource_value = 1.267F;
constexpr int neuron_dopamine_period = 10;
constexpr int synapse_dopamine_period = 10;
constexpr float L_neuron_potential_decay = 1.0 - 1.0 / 3.0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Регистр.

log_stream << std::endl;
}
};
std::cout << "}log obs" << std::endl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В логи.

}


class Target
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Выделить это в отдельный файл.


process_inference_results(spikes, classes_for_testing);
return EXIT_SUCCESS;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Слишком много строк.

@@ -66,7 +66,8 @@ function(knp_set_target_parameters target visibility)

target_compile_definitions("${target}" ${visibility}
# $<$<CONFIG:Debug>:_FORTIFY_SOURCE=2>
$<$<CONFIG:Release>:_FORTIFY_SOURCE=1>)
# $<$<CONFIG:Release>:_FORTIFY_SOURCE=1>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Надо это не закомментить, а сделать правильно.

@@ -0,0 +1,14 @@
cmake_minimum_required(VERSION 3.22)
project(MnistLearnExample)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Комментарий, сайт и прочее.

};


AnnotatedNetwork create_example_network_new(int num_compound_networks)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Что такое AnnotatedNetwork?

// Параметры нейрона по умолчанию. Здесь можно задать те параметры, которые нужны.
ResourceNeuronData default_neuron{{}};
default_neuron.activation_threshold_ = 8.571;
ResourceNeuronData L_neuron = default_neuron;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Регистр и комменты.

L_neuron.d_h_ = -dopamine_value;
L_neuron.dopamine_plasticity_time_ = neuron_dopamine_period;
L_neuron.synapse_sum_threshold_coefficient_ = threshold_weight_coeff;
// L_neuron.w_min_ = min_synaptic_weight;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Удалить.

@@ -1,75 +1,75 @@
#[[
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это здесь откуда?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants