Archive explorer, removal of <CANDIDATE> #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ddn0
reviewed
Apr 22, 2021
| <body onload="init()"> | ||
| <div id="ref_list"></div> | ||
| <script> | ||
| function initList() { |
There was a problem hiding this comment.
I was actually thinking that we make past interviews harder to find rather than easier.
With this change it would technically be possible for a candidate to find old interviews more easily (if they could guess /archive as an interesting path) if I'm understanding it correctly.
There was a problem hiding this comment.
Ok, understood, this is primarily a permission issue then. Here's what I'd like to do:
After a document is first created, anyone who knows the link can read or write it for 2? days. After that, you have to sign in with a Katana login (firebase can do it), then you can read anything (maybe not write).
I'm looking at some documentation to figure out how to do this, does it seem reasonable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.