Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a tool to get graph statistics #556
base: master
Are you sure you want to change the base?
Add a tool to get graph statistics #556
Changes from all commits
55fdce4
ebbdc02
b4d01f1
85d6374
ee6bac8
219e7bb
700d6eb
c758a98
8799b30
fd47343
0f9f797
483f8e7
dcadb19
d2dcd76
0a17c1c
e394465
3bc0023
db586d7
b89b3f4
1b4debf
c2dd1ce
cff612d
92ba1b9
bc3e6d1
148c34d
9ceb2fe
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this calculation correct for
Boolean
types? Is theirsizeof
== 8?We shouldn't have any Booleans in V2 RDGs, but might as well be correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about checking that
myfile
is in a good state before closing? Also, can you check that you write as many bytes as are inserialized
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, maybe this makes your space calculation for Boolean types work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See
Time.h:BytesToStr
(in libsupport) for some good formatting options for sizes and times.