Skip to content

Commit

Permalink
Add rolling CV icons
Browse files Browse the repository at this point in the history
  • Loading branch information
Manisha15 committed Jan 14, 2025
1 parent 27c93d8 commit 1f05d4f
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export const ContentViewEnvironmentDisplay = ({
>
<Label isTruncated color="purple" href={`/lifecycle_environments/${lifecycleEnvironment.id}`}>{lifecycleEnvironment.name}</Label>
</Tooltip>
<ContentViewIcon composite={contentView.composite} style={{ marginRight: '2px' }} position="left" />
<ContentViewIcon composite={contentView.composite} rolling={contentView.rolling} style={{ marginRight: '2px' }} position="left" />

Check failure on line 64 in webpack/components/extensions/HostDetails/Cards/ContentViewDetailsCard/ContentViewDetailsCard.js

View workflow job for this annotation

GitHub Actions / react-tests / Foreman develop Ruby 2.7 and Node 18

'contentView.rolling' is missing in props validation
{contentViewDefault ? <span>{contentView.name}</span> :
<a style={{ fontSize: '14px' }} href={`/content_views/${contentView.id}`}>
{truncate(contentView.name)}
Expand Down
4 changes: 2 additions & 2 deletions webpack/scenes/ContentViews/Publish/CVPublishReview.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import { truncate } from '../../../utils/helpers';

const CVPublishReview = ({
details: {
id, name, composite, next_version: nextVersion,
id, name, composite, rolling, next_version: nextVersion,

Check failure on line 23 in webpack/scenes/ContentViews/Publish/CVPublishReview.js

View workflow job for this annotation

GitHub Actions / react-tests / Foreman develop Ruby 2.7 and Node 18

'details.rolling' is missing in props validation
},
userCheckedItems,
}) => {
Expand Down Expand Up @@ -79,7 +79,7 @@ const CVPublishReview = ({
<Tbody>
<Tr ouiaId="cv-publish-review-table-row">
<Td>
<><ContentViewIcon composite={composite} description={truncate(name)} /><InactiveText text={__('Newly published')} /></>
<><ContentViewIcon composite={composite} rolling={rolling} description={truncate(name)} /><InactiveText text={__('Newly published')} /></>
</Td>
<Td>
{__('Version')} {nextVersion}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ const ContentViewSelectOption = ({ cv, env, value }) => (
>
<ContentViewIcon
composite={cv.composite}
rolling={cv.rolling}

Check failure on line 59 in webpack/scenes/ContentViews/components/ContentViewSelect/ContentViewSelectOption.js

View workflow job for this annotation

GitHub Actions / react-tests / Foreman develop Ruby 2.7 and Node 18

Unexpected tab character

Check failure on line 59 in webpack/scenes/ContentViews/components/ContentViewSelect/ContentViewSelectOption.js

View workflow job for this annotation

GitHub Actions / react-tests / Foreman develop Ruby 2.7 and Node 18

Expected indentation of 8 space characters but found 0

Check failure on line 59 in webpack/scenes/ContentViews/components/ContentViewSelect/ContentViewSelectOption.js

View workflow job for this annotation

GitHub Actions / react-tests / Foreman develop Ruby 2.7 and Node 18

'cv.rolling' is missing in props validation
size="sm"
/>
<Flex
Expand Down
3 changes: 2 additions & 1 deletion webpack/scenes/SmartProxy/ExpandableCvDetails.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ const ExpandableCvDetails = ({
</Thead>
{contentViews.map((cv, rowIndex) => {
const {
id, name: cvName, composite, up_to_date: upToDate,
id, name: cvName, composite, rolling, up_to_date: upToDate,
cvv_id: versionId, cvv_version: version, repositories,
} = cv;
const upToDateVal = upToDate ? <CheckCircleIcon style={{ color: 'green' }} /> : <TimesCircleIcon style={{ color: 'red' }} />;
Expand All @@ -72,6 +72,7 @@ const ExpandableCvDetails = ({
<Td>
<ContentViewIcon
composite={composite}
rolling={rolling}

Check failure on line 75 in webpack/scenes/SmartProxy/ExpandableCvDetails.js

View workflow job for this annotation

GitHub Actions / react-tests / Foreman develop Ruby 2.7 and Node 18

Unexpected tab character

Check failure on line 75 in webpack/scenes/SmartProxy/ExpandableCvDetails.js

View workflow job for this annotation

GitHub Actions / react-tests / Foreman develop Ruby 2.7 and Node 18

Mixed spaces and tabs

Check failure on line 75 in webpack/scenes/SmartProxy/ExpandableCvDetails.js

View workflow job for this annotation

GitHub Actions / react-tests / Foreman develop Ruby 2.7 and Node 18

Expected indentation of 18 space characters but found 0
description={<a href={cv.default ? urlBuilder('products', '') : urlBuilder('content_views', '', id)}>{cvName}</a>}
/>
</Td>
Expand Down

0 comments on commit 1f05d4f

Please sign in to comment.