Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36750 - Add aggregated CV version content counts to count field and return via API #10746

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

sjha4
Copy link
Member

@sjha4 sjha4 commented Sep 19, 2023

What are the changes introduced in this pull request?

Adds aggregated cv_version content count to smart proxy content counts and adds the content counts to API.

Considerations taken when implementing this change?

We need aggregated cv_version content counts to easily display on UI and the aggregated count on the API is good information to have about the synced CV version.

What are the testing steps for this pull request?

Add some repositories of different content types to the CV and publish and promote to an env tied to a smart proxy.
Check the API call for smart_proxy/:id.. You can check this in the network tab when you go to smart proxy details page.
The API return should have a cv_version_content_counts key with aggregated counts of all content types.

@theforeman-bot
Copy link

Issues: #36750

Copy link
Member

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, works well though!

app/models/katello/concerns/smart_proxy_extensions.rb Outdated Show resolved Hide resolved
…d and return via API

(cherry picked from commit dbde8b4)
Copy link
Member

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(sn)ack

@sjha4 sjha4 merged commit 244a606 into Katello:master Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants