Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36794 - Preselect upgradable packages with link on hosts page #10758

Merged

Conversation

lumarel
Copy link
Contributor

@lumarel lumarel commented Oct 1, 2023

What are the changes introduced in this pull request?

Before this change the following button:
image

  • leads to this page:
    image

  • and after the change to this page:
    image

Considerations taken when implementing this change?

The capital letter in "Upgradable" is on purpose or the text in the status dropdown will suddenly show up as all lower letters.

What are the testing steps for this pull request?

  • Make sure the above mentioned click on the "RPM package updates" directly selects the Upgradable packages status
  • The hosts ui's packages page should still work without issues (removing the status, searching, ...)

@theforeman-bot
Copy link

Issues: #36794

@theforeman-bot
Copy link

Can one of the admins verify this patch?

@lumarel
Copy link
Contributor Author

lumarel commented Oct 1, 2023

Oh one note... I don't know couldn't find a standard way how such a selection is normally done, if there is a preferred way I will of course change the PR!

@parthaa
Copy link
Contributor

parthaa commented Oct 4, 2023

[test katello]

Copy link
Member

@jeremylenz jeremylenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Tested and works as advertised 👍

thanks @lumarel !

APJ

@jeremylenz
Copy link
Member

[test katello]

@jeremylenz jeremylenz merged commit 7fb4c8e into Katello:master Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants