-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #36807 - UX fixes and add update count action #10766
Conversation
73af720
to
a64615b
Compare
[test katello] |
I also noticed that failing content counts updates pauses the task. I think we could just make it stop completely and turn into a warning since the json update is all or nothing. |
The latest commit should:
|
47d98b1
to
5ffd73d
Compare
[test katello] |
The updated content count logic seems to be messing up somewhere for me. I have a content view version with a yum repo and a python repo that is promoted to 5 LCEs including Library. All of the LCEs except Library are assigned to my capsule, and only one of those are actually synced. What I'm seeing is this:
63 is my python repo. For some reason, the counts are completely blank even though the smart proxy repo has python packages. The yum content is being recorded, however. |
What did I do now?! Let me look.. 😭 😄 |
I think I see the issue, For example, it calculated the counts for my "Test" LCE first, which included the python repo. "Test" is synced to the smart proxy. Then, it calculated the counts for my "Prod" LCE, which is not yet synced. The counts for the python repo are {} since the
|
So it seems we keep overwriting the content counts as we loop along because we're storing the counts only for the archived repository. However, on the smart proxy, we do sync the promoted repositories separately. Should we go back to showing counts for all promoted repositories? Those are the ones that users consume from at least... I know it confused something in the UI, but I wonder if now the counts aren't showing enough. |
aaf009c
to
870a9da
Compare
Updated PR to:
|
[test katello] |
80bd242
to
65d2e35
Compare
7edd49c
to
15616fa
Compare
15616fa
to
a5982ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is looking good! Gonna do some more in-depth testing tomorrow, but I think it should be good soon.
a5982ec
to
46c7d01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me! Tested some more scenarios with removing LCEs from the smart proxy and the UI handled them well. Only caveat is the issue with the counts not updating if the repo list is completely empty, but that'll be taken care of in #10775
What are the changes introduced in this pull request?
Added task link
Added action on page to refresh counts (Also sets up code to add syncs in the future)
UX fixes
Considerations taken when implementing this change?
What are the testing steps for this pull request?