Fixes #35901 - Allow searching for CCVs based on component CVs #10767
Conversation
| def self.completer_scope_options(search) | ||
| if search.include?('content_views') | ||
| # Don't autocomplete CCV names when searching for components | ||
| { :value_filter => { :composite => false } } | ||
| else | ||
| {} | ||
| end | ||
| end |
There was a problem hiding this comment.
Autocomplete was including composite CV names in the suggested search. For example, if I was searching for content_views = xxx and had typed content_views = , the suggestions would include all of my content view names, including composite content views. But a composite content view cannot contain itself, so this made no sense. To prevent this I added this method, which modifies scoped_search's value filter. I had to modify it to pass in the search because otherwise it would filter out composite CVs when I searched for name = , which we don't want.
app/models/katello/content_view.rb
Outdated
| @@ -111,6 +111,27 @@ class ContentView < Katello::Model | |||
| scoped_search :on => :composite, :complete_value => true | |||
| scoped_search :on => :generated_for, :complete_value => true | |||
| scoped_search :on => :default # just for ordering | |||
| scoped_search :on => :name, :complete_value => true, | |||
| :rename => :content_views, | |||
| :operators => ['=', '!=', '~', '!~'], | |||
There was a problem hiding this comment.
I filtered out the operators like < that don't make much sense here, as well as ^ which just don't seem to work well for this use case
| @@ -111,6 +111,27 @@ class ContentView < Katello::Model | |||
| scoped_search :on => :composite, :complete_value => true | |||
| scoped_search :on => :generated_for, :complete_value => true | |||
| scoped_search :on => :default # just for ordering | |||
| scoped_search :on => :name, :complete_value => true, | |||
| :rename => :content_views, | |||
There was a problem hiding this comment.
I considered naming this components, but we've moved away from using the "component" terminology recently, and I don't want to reverse that.
jeremylenz
force-pushed
the
35901-content-view-inception
branch
2 times, most recently
from
def1eaf to
d65fbc1
Compare
|
fixed rubocop & added unused method args |
|
[test katello] |
1 similar comment
|
[test katello] |
|
The ~ operator seems to be acting weird with content_views..
|
jeremylenz
force-pushed
the
35901-content-view-inception
branch
from
d65fbc1 to
12af004
Compare
jeremylenz
force-pushed
the
35901-content-view-inception
branch
from
12af004 to
46d1545
Compare
|
Updated to only suggest the |
What are the changes introduced in this pull request?
Add a new field to Content View scoped_search. This will allow you to search for a composite content view that contains a particular content view.
For example:
will return composite content views that have My-Content_view as one of their components.
Considerations taken when implementing this change?
I'm still not sure about any performance implications; suggestions welcome
What are the testing steps for this pull request?
Create at least one composite CV but preferably hundreds lol
Search on the Content Views page
Make sure everything works as expected