Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36911 - Org scoping with container tags #10794

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

sjha4
Copy link
Member

@sjha4 sjha4 commented Nov 9, 2023

What are the changes introduced in this pull request?

Add scoping by org to Docker tags on UI which includes products, repos, env etc.

Considerations taken when implementing this change?

What are the testing steps for this pull request?

Have 2 or more organizations
In each, org create the same docker repo and possibly a couple unique docker repos.
Using org switcher, switch orgs and make sure, the tags and product links, environment and repositories tab on tag details are scoped by organization.

Copy link
Member

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well, just one question:

@@ -18,8 +18,26 @@ child :docker_manifest => :manifest do
attributes :schema_version, :digest, :manifest_type
end

child :repositories => :repositories do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we retain the :repositories list even if no organization is specified? Asking since this will be a breaking API change.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point..Updated..

@sjha4 sjha4 force-pushed the container_tag_org branch from 25c372c to b562d61 Compare November 15, 2023 13:16
Copy link
Member

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking fine to me!

@sjha4
Copy link
Member Author

sjha4 commented Nov 16, 2023

[test katello]

@ianballou ianballou merged commit 9309d12 into Katello:master Nov 16, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants