Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37998 - deb-repos not shown on host repo-set #11212

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

m-bucher
Copy link
Contributor

@m-bucher m-bucher commented Nov 8, 2024

What are the changes introduced in this pull request?

Host did not show any debian repositories on Content->RepositorySet tab.
Error-toast is shown.

Todo:

  • test coverage

Considerations taken when implementing this change?

We have to make sure that we do not show duplicate repo-entries in case structured-apt feature is enabled.
That is the reason to also check the environment.

What are the testing steps for this pull request?

  1. create ActivationKey with deb-repositories
  2. register a (deb-)host
  3. go to RepositorySet on new HostDetails' Content-tab
  4. deb-repos are displayed

@m-bucher m-bucher force-pushed the fix_host_deb_rep_set branch 2 times, most recently from 06025be to 11b82ea Compare November 14, 2024 16:18
@m-bucher m-bucher force-pushed the fix_host_deb_rep_set branch from 11b82ea to e41df5c Compare December 3, 2024 07:53
@sbernhard sbernhard merged commit efd860b into Katello:master Dec 3, 2024
26 checks passed
@quba42 quba42 deleted the fix_host_deb_rep_set branch December 3, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants