Fixes #38011 - Apply environment filter for content override #11218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadjaheitmann
force-pushed
the
38011_empty_error_toast
branch
5 times, most recently
from
567e878 to
3bcc7e6
Compare
nadjaheitmann
force-pushed
the
38011_empty_error_toast
branch
from
3bcc7e6 to
272e9f9
Compare
sbernhard
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
When overriding the status on the repository sets page, the state was internally changed. However, it did not show but instead an empty error toast was shown.
Considerations taken when implementing this change?
In structured-apt feature, we use a specific environment to show the correct repo entry, otherwise we would show multiple entries for one repository. We need to apply this environment filter when the override is evaluated.
What are the testing steps for this pull request?