Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #38062 - Fix scoped search for composite key for CVs #11248

Merged

Conversation

nadjaheitmann
Copy link
Contributor

@nadjaheitmann nadjaheitmann commented Dec 4, 2024

What are the changes introduced in this pull request?

Before:
image

After:
image

What are the testing steps for this pull request?

Go to CV overview page and try to use 'composite' as search filter

@nadjaheitmann
Copy link
Contributor Author

@jeremylenz Any opinions about that one? I have seen even more similar problems with boolean search parameters similar to this one (after opening the PR ;) ).

@jeremylenz
Copy link
Member

Yeah, I think :complete_value => true doesn't work well for Boolean fields. We've had to do this in several other places as well.

@chris1984
Copy link
Member

@sbernhard Looks good and has an ack, if you want to merge.

@sbernhard sbernhard merged commit adfb230 into Katello:master Dec 4, 2024
26 checks passed
@nadjaheitmann nadjaheitmann deleted the 38062_fix_bool_scoped_search_for_CVs branch December 5, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants