Fixes #38096 - Fix flat APT repo handling #11259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-bucher
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Code looks good.
Successfully tested syncing flat-repo https://developer.download.nvidia.com/compute/cuda/repos/ubuntu2204/x86_64/.
Proxy sync worked well and could be consumed by subscribed host.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Special handling for APT repos using the flat repository format in order to compensate odd pulp_deb behaviour for such repos.
Considerations taken when implementing this change?
Eventually we want to fix the underlying cause on the pulp_deb side, at which point we can revert this PR. However, the underlying pulp_deb behaviour is much harder to fix and might be some time away. The Katello side fix is pretty simple, and will not have any adverse effects even if pulp_deb behaviour changes.
What are the testing steps for this pull request?
See the reproducer steps in the ticket: https://projects.theforeman.org/issues/38096