refs #37923 - Bug fixes & improvements for the Default HTTP proxy #11266
+25
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stejskalleos
force-pushed
the
ls/fix_http
branch
from
c55a9eb to
55c376d
Compare
Follow up on PR#11183 with:
* Unified naming of the parameter ('content_default_http_proxy')
* On edit form showing information if the capsule is default
* Fixed API + extended show with 'content_default_http_proxy'
stejskalleos
force-pushed
the
ls/fix_http
branch
from
55c376d to
f34a883
Compare
|
@jeremylenz review please |
|
@ianballou hi, anyone available for a review? |
|
I'll double check that this is on our to-do list on Monday |
2 tasks
Lennonka
reviewed
Jan 13, 2025
| param :http_proxy, Hash do | ||
| param :default_content_proxy, :bool, :required => false, :desc => N_('Set this HTTP proxy as the default content HTTP proxy') | ||
| param :content_default_http_proxy, :bool, :required => false, :desc => N_('Set this HTTP proxy as the default content HTTP proxy') |
There was a problem hiding this comment.
Suggested change
| param :content_default_http_proxy, :bool, :required => false, :desc => N_('Set this HTTP proxy as the default content HTTP proxy') | |
| param :default_content_http_proxy, :bool, :required => false, :desc => N_('Set this HTTP proxy as the default content HTTP proxy') |
Should this be the name to be consistent with the UI option?
There was a problem hiding this comment.
The setting has the key content_default_http_proxy, so I'd like to keep it in sync with it.
|
Test failures are unrelated, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #11183 with