Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36347 - Remove YumMetadataFile #11312

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jturel
Copy link
Member

@jturel jturel commented Feb 15, 2025

I see this poor issue has been bumped from release to release and decided to give it a shot.

What are the changes introduced in this pull request?

Removes YumMetadataFile model and supporting code

Considerations taken when implementing this change?

There are some leftovers that I think are still used(?)

git grep -i metadatafile app/
app/lib/katello/util/pulpcore_content_filters.rb:      def filter_metadatafiles_by_pulp_hrefs(metadatafiles_results, _package_pulp_hrefs)
app/lib/katello/util/pulpcore_content_filters.rb:        metadatafiles_results.collect { |result| result.pulp_href }.flatten.uniq
app/services/katello/pulp3/api/yum.rb:          PulpRpmClient::ContentRepoMetadataFilesApi.new(api_client)
app/services/katello/pulp3/repository/yum.rb:        def metadatafiles(options = {})
app/services/katello/pulp3/repository/yum.rb:          metadata_file_hrefs_to_include = filter_metadatafiles_by_pulp_hrefs(
app/services/katello/pulp3/repository/yum.rb:            repo_service.metadatafiles(options)&.results, content_unit_hrefs)

What are the testing steps for this pull request?

Make sure there's a green build and ... anything else?

@jturel jturel force-pushed the remove_yum_metadata_file branch from 7c151ca to 25ef180 Compare February 15, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant