fix(auctions): min bid wasn't calculated correctly for tiny auctions #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replace deprecated exportloopref with copyloopvar - move skip-dirs to issues section - remove some broken configs in favour of defaults
dockerfile was running into build errors
nddeluca
reviewed
Mar 4, 2025
| @@ -1,4 +1,4 @@ | |||
| FROM golang:1.21.9-bookworm as build-env | |||
| FROM golang:1.23.6-bookworm AS build-env | |||
There was a problem hiding this comment.
Nice thnx for updating and fixing the case warning
nddeluca
reviewed
Mar 4, 2025
| @@ -258,18 +261,25 @@ func calculateUSDValue(coin sdk.Coin, assetInfo AssetInfo) sdk.Dec { | |||
| return coin.Amount.ToLegacyDec().Quo(assetInfo.ConversionFactor.ToLegacyDec()).Mul(assetInfo.Price) | |||
| } | |||
|
|
|||
| // calculateProposedBid tries to find a bid amount for a forward auction. | |||
nddeluca
reviewed
Mar 4, 2025
| return currentBid.Add( // new bids must be some % greater than old bid, and at least 1 larger to avoid replacing an old bid at no cost | ||
| sdk.MaxInt( | ||
| sdk.NewInt(1), | ||
| sdk.NewDecFromInt(currentBid).Mul(increment).RoundInt(), |
There was a problem hiding this comment.
Thnx for removing the hard coded increment
nddeluca
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For tiny (forward) auctions, the bot could bid the same as the current bid. This is never allowed by the chain as all bids must at least be 1 unit larger than previous.
This PR replicates the bug in a test and copies in the min bid calculation from the auction module.