fix(cli): loading configuration files #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic for searching for the config file was incorrectly pushing paths to the PathBuf without popping, causing it to look for the wrong file paths.
|
Thank you very much! |
KeisukeYamashita
changed the title
KeisukeYamashita
approved these changes
Jan 10, 2024
KeisukeYamashita
merged commit 4b86b48
into
KeisukeYamashita:main
14 of 16 checks passed
|
I have released the new version, thank you! 👉 https://github.com/KeisukeYamashita/commitlint-rs/releases/tag/v0.1.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for searching for the config file was incorrectly pushing paths to the PathBuf without popping, causing it to look for the wrong file paths.
Why
I found that it was not detecting the yaml configuration files. I investigated and found this.