Skip to content

Commit

Permalink
Revert "Remove non-standard contextMenus.create"
Browse files Browse the repository at this point in the history
This reverts commit ab19d0d.  That was introduced in PR #26 as an alternative approach to #27.  However with the more consistent solution of #27, `contextMenus.create` should be promisified, in order to ensure a consistent API (so it returns a Promise, like everything else).
  • Loading branch information
dlh3 committed Sep 29, 2020
1 parent c6d346c commit 5a705c4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion chrome-extension-async.js
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@
{ n: 'camera', props: knownInContentSetting },
{ n: 'unsandboxedPlugins', props: knownInContentSetting },
{ n: 'automaticDownloads', props: knownInContentSetting }],
contextMenus: ['update', 'remove', 'removeAll'], /* 'create' omitted intentionally, it does not follow standard asynchronous pattern */
contextMenus: ['create', 'update', 'remove', 'removeAll'],
cookies: ['get', 'getAll', 'set', 'remove', 'getAllCookieStores'],
debugger: ['attach', 'detach', 'sendCommand', 'getTargets'],
desktopCapture: ['chooseDesktopMedia'],
Expand Down

0 comments on commit 5a705c4

Please sign in to comment.