Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add possibility to do auth for Aqua SaaS near default auth Aqua. #551

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Add possibility to do auth for Aqua SaaS near default auth Aqua. #551

merged 1 commit into from
Jul 9, 2024

Conversation

Ukhanskyi
Copy link
Contributor

@Ukhanskyi Ukhanskyi commented Jul 3, 2024 •
edited
Loading

Trying to connect to Aqua SaaS, near existing authentication logic.

GitHub Issue

@Ukhanskyi
Copy link
Contributor Author

@jgarber, @shotop, @scotttesler, @JaiHirsch, Hi everyone 👋🏼)
Would it be possible for someone to review these changes for the Aqua connector and merge them if everything is correct?

@Ukhanskyi Ukhanskyi force-pushed the add_aqua_saas_authentication branch from fe739b0 to 03e1068 Compare July 3, 2024 21:29
@Ukhanskyi
Copy link
Contributor Author

@jgarber-cisco, or maybe you could to check this code during your business hours.

jgarber-cisco
jgarber-cisco approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@jgarber-cisco jgarber-cisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question about whether this breaks on-prem, but otherwise, LGTM!

tasks/connectors/aqua/lib/aqua_helper.rb Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 8, 2024
View reviewed changes
tasks/connectors/aqua/lib/aqua_helper.rb Fixed Show resolved Hide resolved
tasks/connectors/aqua/aqua.rb Fixed Show resolved Hide resolved
@jgarber-cisco
Copy link
Contributor

@Ukhanskyi Rebase to pick up the security upgrades from main

jgarber-cisco
jgarber-cisco requested changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@jgarber-cisco jgarber-cisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase, look at on-prem, and make cloud url checking safer.

@Ukhanskyi Ukhanskyi force-pushed the add_aqua_saas_authentication branch from 03e1068 to d085785 Compare July 8, 2024 20:17
@Ukhanskyi
Copy link
Contributor Author

Ukhanskyi commented Jul 8, 2024 •
edited
Loading

Rebase, look at on-prem, and make cloud url checking safer.

@jgarber-cisco
Rebased on the main branch and squashed all commits. I returned the 'id' for on-prem, and also tried to make the URL check more accurate and safe. Could you review this code one more time, please

jgarber-cisco
jgarber-cisco approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@jgarber-cisco jgarber-cisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@jgarber-cisco jgarber-cisco merged commit f7d9bff into KennaSecurity:main Jul 9, 2024
6 checks passed
@Ukhanskyi Ukhanskyi deleted the add_aqua_saas_authentication branch October 27, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgarber-cisco jgarber-cisco jgarber-cisco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ukhanskyi @jgarber-cisco