Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update http.rb #561

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Update http.rb #561

merged 4 commits into from
Nov 21, 2024

Conversation

netplwiz
Copy link
Contributor

Add retry to ServerBrokeConnection

Add retry to ServerBrokeConnection
@netplwiz netplwiz self-assigned this Oct 18, 2024
Copy link
Contributor

@jgarber-cisco jgarber-cisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I didn't know this file existed. Let's call it "interesting!"

You followed suit and addressed the problem, thanks!

Copy link
Contributor

@jgarber-cisco jgarber-cisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, looks like linting and tests are failing because of this change. I upgraded ReXML, so that should no longer error with vulnerabilities.

2024-10-31 20:53:35 [INFO]   File:[/github/workspace/lib/http.rb]
2024-10-31 20:53:36 [ERROR]   Found errors in [rubocop] linter!
2024-10-31 20:53:36 [ERROR]   Error code: 1. Command output:
------
Inspecting 1 file
E

Offenses:

lib/http.rb:47:9: E: Lint/Syntax: unexpected token kRESCUE
(Using Ruby 3.2 parser; configure using TargetRubyVersion parameter, under AllCops)
        rescue RestClient::ExceptionWithResponse => e
        ^^^^^^
lib/http.rb:55:9: E: Lint/Syntax: unexpected token kRESCUE
(Using Ruby 3.2 parser; configure using TargetRubyVersion parameter, under AllCops)
        rescue RestClient::NotFound => e
        ^^^^^^
lib/http.rb:57:9: E: Lint/Syntax: unexpected token kRESCUE
(Using Ruby 3.2 parser; configure using TargetRubyVersion parameter, under AllCops)
        rescue RestClient::Exception => e
        ^^^^^^
lib/http.rb:65:9: E: Lint/Syntax: unexpected token kRESCUE
(Using Ruby 3.2 parser; configure using TargetRubyVersion parameter, under AllCops)
        rescue Errno::ECONNREFUSED => e
        ^^^^^^
lib/http.rb:161:1: E: Lint/Syntax: unexpected token $end
(Using Ruby 3.2 parser; configure using TargetRubyVersion parameter, under AllCops)

1 file inspected, 5 offenses detected

Copy link
Contributor

@jgarber-cisco jgarber-cisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, all checks are passing now

@jgarber-cisco jgarber-cisco merged commit 938d17d into main Nov 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants