Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blazor rewrite #383

Closed
wants to merge 4 commits into from
Closed

Blazor rewrite #383

wants to merge 4 commits into from

Conversation

kentico-ericd
Copy link
Member

@JosefDvorak JosefDvorak self-assigned this Jun 6, 2024
Copy link
Collaborator

@JosefDvorak JosefDvorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most issues are trivial or cosmetic. However, there are a few changes to structure that should be made, to keep consistency with other Kentico repos.

@@ -0,0 +1,2 @@
UPDATE CMS_WebFarmServer SET ServerDisplayName = ServerDisplayName + N'.disabled', ServerEnabled = 0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If run multiple times, appends ".disabled" repeatedly.
This is mostly a cosmetic issue.

@@ -0,0 +1,2 @@
UPDATE Staging_Server SET ServerDisplayName = ServerDisplayName + N'.disabled', ServerEnabled = 0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If run multiple times, appends ".disabled" repeatedly.
This is mostly a cosmetic issue.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If run multiple times, appends ".disabled" repeatedly.
This is mostly a cosmetic issue.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Column ServerAuthenticationType was only added in Kentico Xperience 13 refresh, to enable OAuth SMTP server authentication. This makes this report incompatible with earlier version.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Column ServerAuthenticationType was only added in Kentico Xperience 13 refresh, to enable OAuth SMTP server authentication. This makes this report incompatible with earlier version.

###############################################################################
# Set default behavior to automatically normalize line endings.
###############################################################################
* text=auto
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normalizing line encoding can be useful to avoid issues when merging. I'll accept this change for now, but if we run into issues in future, we may need to re-introduce this configuration.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The license file should not be arbitrarily re-written.

@JosefDvorak JosefDvorak mentioned this pull request Jan 14, 2025
5 tasks
@JosefDvorak
Copy link
Collaborator

Merged as part of #384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants