Character device driver implementation is finish #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty shell script file is created Signed-off-by: Oleksandr Shmatko <[email protected]>
Signed-off-by: Oleksandr Shmatko <[email protected]>
…tion Add commnd for /realise branch create Add command for copy .c files to /tmp/guesanumber Add functions for archivating .c files from /tmp/guesanumber to release/guesanumber.tar.gz Signed-off-by: Oleksandr Shmatko <[email protected]>
"tmp/guesanumber" defined as $tmpDir variable; "realise" defined as $realiseDir variable; add chiking of existing $tmpDir variable; add remooving $tmpDir at scritp finish Signed-off-by: Oleksandr Shmatko <[email protected]>
Empty line is added to the end of script Signed-off-by: Oleksandr Shmatko <[email protected]>
Signed-off-by: Oleksandr Shmatko <[email protected]>
Signed-off-by: Oleksandr Shmtko <[email protected]>
shmatko1095
changed the title
oleg-h2o
requested changes
Apr 17, 2019
| } | ||
| printk(KERN_INFO "chrdev: Device initialized succesfully\n"); | ||
|
|
||
| buffer_create(); |
There was a problem hiding this comment.
The functions buffer_crerate() and create_proc() can return errors, but these errors are ignored here.
oleg-h2o
added
changes requested
Added error handring of buffer_create() and create_proc() in chrdev_init() function; Signed-off-by: Oleksandr Shmtko <[email protected]>
shmatko1095
added
ready
oleg-h2o
reviewed
Apr 23, 2019
| } | ||
| printk(KERN_INFO "chrdev: Device initialized succesfully\n"); | ||
|
|
||
| if (0 == err) err = buffer_create(); |
There was a problem hiding this comment.
If buffer_create() (or create_proc()) fails here, you should immediately return with error code...
galkinletter
requested changes
Apr 23, 2019
| module_init(chrdev_init); | ||
| module_exit(chrdev_exit); | ||
|
|
||
| MODULE_LICENSE("GPL"); |
There was a problem hiding this comment.
Suggested change
| MODULE_LICENSE("GPL"); | |
| MODULE_LICENSE("GPL"); | |
| MODULE_AUTHOR(""); | |
| MODULE_DESCRIPTION(""); | |
| MODULE_VERSION("0.1"); |
Please fix description. Add AUTHOR, version
| #endif | ||
|
|
||
| #define BUFFER_SIZE 1024 | ||
| #define DEVICE_NAME "charDevice" |
There was a problem hiding this comment.
Suggested change
| #define DEVICE_NAME "charDevice" | |
| #define DEVICE_NAME "charDevice" | |
| #define CLASS_NAME "charClass" |
Please use kernel code style https://www.kernel.org/doc/html/v4.10/process/coding-style.html
Please use Check kernel code with checkpatch
| clean: | ||
| $(MAKE) -C $(KERNELDIR) M=$(CURDIR) clean | ||
|
|
||
| endif |
There was a problem hiding this comment.
Suggested change
| endif | |
| endif | |
Please fix end of line
galkinletter
added
changes requested
DEVICE_NAME, CLASS_NAME changed according to linux-codestyle; chrdev_init(void) immediately returns an error if it is. Signed-off-by: Oleksandr Shmtko <[email protected]>
shmatko1095
added
ready
oleg-h2o
requested changes
May 7, 2019
|
|
||
| err = create_proc(); | ||
| if (IS_ERR(err)) { | ||
| class_destroy(pclass); |
There was a problem hiding this comment.
Memory have allocated here. Do free it on error handling.
|
|
||
| err = buffer_create(); | ||
| if (IS_ERR(err)) { | ||
| class_destroy(pclass); |
galkinletter
added
changes requested
galkinletter
requested changes
May 7, 2019
galkinletter
added
ready
|
Please fix ASAP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Character device driver implementation is finish
Please review