Lesson mpu6050 #146
Open
Lesson mpu6050 #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniil Petrov <[email protected]>
Signed-off-by: Daniil Petrov <[email protected]>
Signed-off-by: Daniil Petrov <[email protected]>
Signed-off-by: Daniil Petrov <[email protected]>
Signed-off-by: Daniil Petrov <[email protected]>
Signed-off-by: Daniil Petrov <[email protected]>
Signed-off-by: Daniil Petrov <[email protected]>
Signed-off-by: Daniil Petrov <[email protected]>
Signed-off-by: Daniil Petrov <[email protected]>
Signed-off-by: Daniil Petrov <[email protected]>
yekovalyov
reviewed
May 10, 2019
| h = i2c_smbus_read_byte_data(gl_mpu6050_data.drv_client, REG_ACCEL_YOUT_H); | ||
| l = i2c_smbus_read_byte_data(gl_mpu6050_data.drv_client, REG_ACCEL_YOUT_L); | ||
| t = (h << 8 | l); | ||
| gl_mpu6050_data.accel_values[1] = (t & 0x7fff) - (t & 0x8000); |
There was a problem hiding this comment.
What is the reason for this conversation? Variable t is already 16 bit long.
yekovalyov
suggested changes
May 10, 2019
| uint8_t h; | ||
| uint8_t l; | ||
| uint16_t t; | ||
| h = i2c_smbus_read_byte_data(gl_mpu6050_data.drv_client, REG_ACCEL_YOUT_H); |
There was a problem hiding this comment.
It is possible to read complete work using i2c_smbus_read_word_swapped()
| gl_mpu6050_data.temperatureF[1] = ((result*9/5)+32*DISCHARGE) % DISCHARGE; | ||
| printk(KERN_INFO "Temperature: %d.%03d C\n", gl_mpu6050_data.temperatureC[0], gl_mpu6050_data.temperatureC[1]); | ||
| printk(KERN_INFO "Temperature: %d.%03d F\n", gl_mpu6050_data.temperatureF[0], gl_mpu6050_data.temperatureF[1]); | ||
| sprintf(buf,"Temperature: %d.%03d C\nTemperature: %d.%03d F\n", gl_mpu6050_data.temperatureC[0], gl_mpu6050_data.temperatureC[1], gl_mpu6050_data.temperatureF[0], gl_mpu6050_data.temperatureF[1]); |
There was a problem hiding this comment.
How mane symbols in this string? Please check your code with checkpatch.pl
yekovalyov
added
changes requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MPU6050 Practice. Kernel object module development
Homework
@galkinletter @oleg-h2o Check please my task.