homework #49
Open
homework #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AleksandrBulyshchenko
requested changes
Jan 10, 2018
There was a problem hiding this comment.
My review is quite shallow and without testing.
The exercise overall is done, despite doesn't fully conform the task.
But:
- All the changes merged into baseline sources, which make it almost impossible to provide normal review;
- No description of what is done;
${KERNEL_SOURCE}/scripts/checkpatch.pl --file lesson-8-Character-Devices/*.c --terse:
total: 45 errors, 49 warnings, 285 lines checked.
The PR should be formatted according to the wiki.
| static struct i2c_driver mpu6050_i2c_driver = { .driver = | ||
| { .name = "gl_mpu6050", }, | ||
|
|
||
| .probe = mpu6050_probe, .remove = mpu6050_remove, .id_table = mpu6050_idtable, }; |
There was a problem hiding this comment.
Code formatting is just fantastic sometime.
| if (kthread_should_stop()) { | ||
| do_exit(0); | ||
| } | ||
| mpu6050_read_data(&g_mpu6050_data[number]); |
There was a problem hiding this comment.
This's not a big deal, but, AFAIR, the task was to read sensor data only by request (but not more often than once per second) - not each second.
But there's an actual issue - no synchronization between reading and writing number and g_mpu6050_data[].
AleksandrBulyshchenko
assigned AleksandrBulyshchenko and sashanikitin and unassigned AleksandrBulyshchenko
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mpu6050 with kthread