Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

running formatting #28

Merged
merged 13 commits into from
Dec 4, 2023

Merge pull request #29 from KevinSchildhorn/ktFormat2

d4f488c
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

running formatting #28

Merge pull request #29 from KevinSchildhorn/ktFormat2
d4f488c
Select commit
Loading
Failed to load commit list.
GitHub Actions / ktlint failed Dec 4, 2023 in 0s

reviewdog [ktlint] report

reported by reviewdog 🐶

Findings (11)

shared/src/androidMain/kotlin/Main.android.kt|7 col 5| Function name should start with a lowercase letter (except factory methods) and use camel case
shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/data/LoginCredentials.kt|16 col 1| Unexpected indentation (20) (should be 16)
shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/data/LoginCredentials.kt|17 col 1| Unexpected indentation (20) (should be 16)
shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/data/LoginCredentials.kt|18 col 1| Unexpected indentation (20) (should be 16)
shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/LoginScreen.kt|36 col 1| Unexpected indentation (12) (should be 16)
shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/LoginScreen.kt|40 col 1| Unexpected indentation (12) (should be 16)
shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/common/ErrorView.kt|27 col 1| Unexpected indentation (8) (should be 12)
shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/common/ErrorView.kt|29 col 1| Unexpected indentation (12) (should be 16)
shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/common/ErrorView.kt|30 col 1| Unexpected indentation (8) (should be 12)
shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/common/PrimaryButton.kt|29 col 1| Unexpected indentation (8) (should be 12)
shared/src/iosMain/kotlin/Main.ios.kt|5 col 5| Function name should start with a lowercase letter (except factory methods) and use camel case

Filtered Findings (49)

androidApp/src/androidMain/kotlin/com/kevinschildhorn/MainActivity.kt|13 col 1| Class body should not start with blank line
atomik/src/androidMain/kotlin/com/kevinschildhorn/atomik/atomic/atoms/xml/TextViewExtensions.kt|29 col 36| Newline expected after opening parenthesis
atomik/src/androidMain/kotlin/com/kevinschildhorn/atomik/atomic/atoms/xml/TextViewExtensions.kt|29 col 59| Parameter should start on a newline
atomik/src/androidMain/kotlin/com/kevinschildhorn/atomik/atomic/atoms/xml/TextViewExtensions.kt|29 col 85| Newline expected before closing parenthesis
atomik/src/androidMain/kotlin/com/kevinschildhorn/atomik/typography/AtomikTypographyExtensions.kt|23 col 13| A multiline expression should start on a new line
atomik/src/androidMain/kotlin/com/kevinschildhorn/atomik/typography/PlatformTypographySet.kt|1 col 1| File 'PlatformTypographySet.kt' should not be empty
atomik/src/commonMain/kotlin/com/kevinschildhorn/atomik/atomic/atoms/ButtonAtom.kt|1 col 1| File 'ButtonAtom.kt' should not be empty
atomik/src/commonMain/kotlin/com/kevinschildhorn/atomik/atomic/atoms/ImageAtom.kt|1 col 1| File 'ImageAtom.kt' should not be empty
atomik/src/commonMain/kotlin/com/kevinschildhorn/atomik/color/DefaultColorSet.kt|1 col 1| File 'DefaultColorSet.kt' should not be empty
atomik/src/commonMain/kotlin/com/kevinschildhorn/atomik/typography/DefaultTypographySet.kt|1 col 1| File 'DefaultTypographySet.kt' should not be empty
atomik/src/commonMain/kotlin/com/kevinschildhorn/atomik/typography/PlatformTypographySet.kt|1 col 1| File 'PlatformTypographySet.kt' should not be empty
atomik/src/iosMain/kotlin/com/kevinschildhorn/atomik/color/base/AtomikColor.kt|24 col 17| A multiline expression should start on a new line
atomik/src/iosMain/kotlin/com/kevinschildhorn/atomik/typography/+TypographyWeight.kt|20 col 13| A multiline expression should start on a new line
atomik/src/iosMain/kotlin/com/kevinschildhorn/atomik/typography/PlatformTypographySet.kt|1 col 1| File 'PlatformTypographySet.kt' should not be empty
atomik/src/jvmMain/kotlin/com/kevinschildhorn/atomik/atomic/atoms/+Modifier.kt|17 col 66| First line of body expression fits on same line as function signature
desktopApp/src/desktopMain/kotlin/Main.kt|4 col 14| A multiline expression should start on a new line
desktopApp/src/desktopMain/kotlin/Main.kt|4 col 14| Newline expected before expression body
desktopApp/src/jvmMain/kotlin/Main.kt|5 col 14| A multiline expression should start on a new line
desktopApp/src/jvmMain/kotlin/Main.kt|5 col 14| Newline expected before expression body
shared/src/androidMain/kotlin/com/kevinschildhorn/fotopresenter/KoinAndroid.kt|26 col 46| A multiline expression should start on a new line
shared/src/androidMain/kotlin/com/kevinschildhorn/fotopresenter/KoinAndroid.kt|29 col 24| A multiline expression should start on a new line
shared/src/androidMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/Previews.kt|18 col 5| Function name should start with a lowercase letter (except factory methods) and use camel case
shared/src/androidMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/Previews.kt|24 col 5| Function name should start with a lowercase letter (except factory methods) and use camel case
shared/src/androidMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/Previews.kt|30 col 5| Function name should start with a lowercase letter (except factory methods) and use camel case
shared/src/androidMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/Previews.kt|41 col 5| Function name should start with a lowercase letter (except factory methods) and use camel case
shared/src/androidMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/Previews.kt|51 col 5| Function name should start with a lowercase letter (except factory methods) and use camel case
shared/src/androidMain/kotlin/com/kevinschildhorn/fotopresenter/ui/viewmodel/ViewModel.kt|9 col 5| Expected a blank line for this declaration
shared/src/commonMain/kotlin/App.kt|11 col 5| Function name should start with a lowercase letter (except factory methods) and use camel case
shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/DirectoryScreen.kt|9 col 5| Function name should start with a lowercase letter (except factory methods) and use camel case
shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/LoginScreen.kt|22 col 5| Function name should start with a lowercase letter (except factory methods) and use camel case
shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/LoginScreen.kt|37 col 1| Unexpected indentation (16) (should be 20)
shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/LoginScreen.kt|38 col 1| Unexpected indentation (16) (should be 20)
shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/LoginScreen.kt|39 col 1| Unexpected indentation (16) (should be 20)
shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/common/ErrorView.kt|15 col 5| Function name should start with a lowercase letter (except factory methods) and use camel case
shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/common/ErrorView.kt|28 col 1| Unexpected indentation (12) (should be 16)
shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/common/FormColumn.kt|14 col 12| Function name should start with a lowercase letter (except factory methods) and use camel case
shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/common/PrimaryButton.kt|17 col 5| Function name should start with a lowercase letter (except factory methods) and use camel case
shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/common/PrimaryButton.kt|30 col 1| Unexpected indentation (12) (should be 16)
shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/common/PrimaryButton.kt|31 col 1| Unexpected indentation (12) (should be 16)
shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/common/PrimaryButton.kt|32 col 1| Unexpected indentation (8) (should be 12)
shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/common/TitleView.kt|12 col 5| Function name should start with a lowercase letter (except factory methods) and use camel case
shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/login/FotoCheckbox.kt|13 col 5| Function name should start with a lowercase letter (except factory methods) and use camel case
shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/login/FotoTextField.kt|14 col 5| Function name should start with a lowercase letter (except factory methods) and use camel case
shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/login/FotoTextField.kt|38 col 5| Function name should start with a lowercase letter (except factory methods) and use camel case
shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/login/LoginScreenForm.kt|18 col 5| Function name should start with a lowercase letter (except factory methods) and use camel case
shared/src/desktopMain/kotlin/com/kevinschildhorn/fotopresenter/KoinDesktop.kt|17 col 46| A multiline expression should start on a new line
shared/src/iosMain/kotlin/com/kevinschildhorn/fotopresenter/KoiniOS.kt|24 col 46| A multiline expression should start on a new line
shared/src/iosMain/kotlin/com/kevinschildhorn/fotopresenter/KoiniOS.kt|27 col 33| A multiline expression should start on a new line
shared/src/jvmMain/kotlin/com/kevinschildhorn/fotopresenter/data/network/SMBJHandler.kt|65 col 20| A multiline expression should start on a new line

Annotations

Check failure on line 7 in shared/src/androidMain/kotlin/Main.android.kt

See this annotation in the file changed.

@github-actions github-actions / ktlint

[ktlint] shared/src/androidMain/kotlin/Main.android.kt#L7 <standard:function-naming>

Function name should start with a lowercase letter (except factory methods) and use camel case
Raw output
shared/src/androidMain/kotlin/Main.android.kt:7:5: error: Function name should start with a lowercase letter (except factory methods) and use camel case (standard:function-naming)

Check failure on line 16 in shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/data/LoginCredentials.kt

See this annotation in the file changed.

@github-actions github-actions / ktlint

[ktlint] shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/data/LoginCredentials.kt#L16 <standard:indent>

Unexpected indentation (20) (should be 16)
Raw output
shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/data/LoginCredentials.kt:16:1: error: Unexpected indentation (20) (should be 16) (standard:indent)

Check failure on line 17 in shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/data/LoginCredentials.kt

See this annotation in the file changed.

@github-actions github-actions / ktlint

[ktlint] shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/data/LoginCredentials.kt#L17 <standard:indent>

Unexpected indentation (20) (should be 16)
Raw output
shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/data/LoginCredentials.kt:17:1: error: Unexpected indentation (20) (should be 16) (standard:indent)

Check failure on line 18 in shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/data/LoginCredentials.kt

See this annotation in the file changed.

@github-actions github-actions / ktlint

[ktlint] shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/data/LoginCredentials.kt#L18 <standard:indent>

Unexpected indentation (20) (should be 16)
Raw output
shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/data/LoginCredentials.kt:18:1: error: Unexpected indentation (20) (should be 16) (standard:indent)

Check failure on line 36 in shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/LoginScreen.kt

See this annotation in the file changed.

@github-actions github-actions / ktlint

[ktlint] shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/LoginScreen.kt#L36 <standard:indent>

Unexpected indentation (12) (should be 16)
Raw output
shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/LoginScreen.kt:36:1: error: Unexpected indentation (12) (should be 16) (standard:indent)

Check failure on line 40 in shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/LoginScreen.kt

See this annotation in the file changed.

@github-actions github-actions / ktlint

[ktlint] shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/LoginScreen.kt#L40 <standard:indent>

Unexpected indentation (12) (should be 16)
Raw output
shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/LoginScreen.kt:40:1: error: Unexpected indentation (12) (should be 16) (standard:indent)

Check failure on line 27 in shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/common/ErrorView.kt

See this annotation in the file changed.

@github-actions github-actions / ktlint

[ktlint] shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/common/ErrorView.kt#L27 <standard:indent>

Unexpected indentation (8) (should be 12)
Raw output
shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/common/ErrorView.kt:27:1: error: Unexpected indentation (8) (should be 12) (standard:indent)

Check failure on line 29 in shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/common/ErrorView.kt

See this annotation in the file changed.

@github-actions github-actions / ktlint

[ktlint] shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/common/ErrorView.kt#L29 <standard:indent>

Unexpected indentation (12) (should be 16)
Raw output
shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/common/ErrorView.kt:29:1: error: Unexpected indentation (12) (should be 16) (standard:indent)

Check failure on line 30 in shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/common/ErrorView.kt

See this annotation in the file changed.

@github-actions github-actions / ktlint

[ktlint] shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/common/ErrorView.kt#L30 <standard:indent>

Unexpected indentation (8) (should be 12)
Raw output
shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/common/ErrorView.kt:30:1: error: Unexpected indentation (8) (should be 12) (standard:indent)

Check failure on line 29 in shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/common/PrimaryButton.kt

See this annotation in the file changed.

@github-actions github-actions / ktlint

[ktlint] shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/common/PrimaryButton.kt#L29 <standard:indent>

Unexpected indentation (8) (should be 12)
Raw output
shared/src/commonMain/kotlin/com/kevinschildhorn/fotopresenter/ui/compose/common/PrimaryButton.kt:29:1: error: Unexpected indentation (8) (should be 12) (standard:indent)

Check failure on line 5 in shared/src/iosMain/kotlin/Main.ios.kt

See this annotation in the file changed.

@github-actions github-actions / ktlint

[ktlint] shared/src/iosMain/kotlin/Main.ios.kt#L5 <standard:function-naming>

Function name should start with a lowercase letter (except factory methods) and use camel case
Raw output
shared/src/iosMain/kotlin/Main.ios.kt:5:5: error: Function name should start with a lowercase letter (except factory methods) and use camel case (standard:function-naming)