Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Migrate use of hashValues to Object.hash #12

Merged
merged 2 commits into from
Dec 21, 2024

Conversation

shatanikmahanty
Copy link
Contributor

@shatanikmahanty shatanikmahanty commented Dec 12, 2024

Flutter's latest stable has removed the method hashValues.

This PR fixes that to use Object.hash method

@shatanikmahanty
Copy link
Contributor Author

@KevinVan720 could you please review this and release a new pub version. It would be very much helpful. Thanks!

@JohnSamy11
Copy link

be aware that the dimension: ^0.1.7 package included in the .yaml file also contains the same issue internally @shatanikmahanty

@shatanikmahanty
Copy link
Contributor Author

be aware that the dimension: ^0.1.7 package included in the .yaml file also contains the same issue internally @shatanikmahanty

@JohnSamy11 I had also created a PR there, it was merged. Once it will be live in pub.dev. I will update this PR

@wantroba
Copy link

any prediction of when it will be on pub.dev?

@KevinVan720
Copy link
Owner

@shatanikmahanty Thank you for the PR. I have published a new version for the dimension package. I will update the version myself and publish a new version for this package.

@KevinVan720 KevinVan720 merged commit 137b335 into KevinVan720:main Dec 21, 2024
1 check failed
@shatanikmahanty
Copy link
Contributor Author

@shatanikmahanty Thank you for the PR. I have published a new version for the dimension package. I will update the version myself and publish a new version for this package.

Thank you for this ❤️

@wantroba
Copy link

Tks @shatanikmahanty and @KevinVan720 . Version 2.0.0 works like a charm ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants