-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve: GUI messages for signing algorithm in CA creation form #773
base: main
Are you sure you want to change the base?
Improve: GUI messages for signing algorithm in CA creation form #773
Conversation
I like the localization, but not the change to "None alternative signature". The original text makes it very easy to understand imho, while the new one makes it sounds like you should select one. |
Some feedback from someone who has not been using EJBCA in a while. I can see where David is coming from. Suppose admin A picks an alternative signing algorithm in the dropdown. Two days later, admin B is told to disable the alternative signature. When he goes into the GUI it is unclear that "disabling the alternative signature" means picking "Select an algorithm" in the dropdown. I don't think "- None alternative signature -" is grammatically correct though. Should probably be "- No alternative signature -". Personally I think that's an improvement over what we have now. |
That is not a possible use case. Once the CA has been created it is not possible to edit the CA an unselect the alternative algorithm. I.e. once you created your hybrid CA there is no going back (actually there is in using the CLI, but then you really know what you're doing anyway). |
In "Approval Settings" (in this same form), there are drop down lists, and I don't think that anyone think "I should select one". |
You have not presented a good argument to change it imho. The only argument I can read above is that it "should look like the other drop-downs". I am pretty sure, all my experience says so, that we will get support issues if it looks like a "normal" drop down. This is not a normal drop down. I'd rather have more hoops to go through in order to activate hybrid than less. The help text below is not visible enough for warnings. Can you make the final decision @mike-agrenius-kushner . |
My new proposal with the message "Select an alternative signing algorithm to activate hybrid certificates" in red color (style 'warning'), like another texts in the page. I keep the word "None" to be consistent with "Approval Settings" dropdown lists (in the same page). What do you think about this new proposal @primetomas , @mike-agrenius-kushner ? |
Change description
Improve messages for signing algorithm, in CA creation form:
ALTERNATIVESIGNINGALGORITHM
toSIGNINGALGORITHM_ALTERNATIVE
, and move it (better for localizators ;-))Note: the message "None alternative signature" is better than original, because we can select an algorithm, then select back this first option. It is not the same behavior than the Crypto Token drop list one.
Before
![EJBCA_Admin-GUI_Signing-algorithm_1-BEFORE](https://private-user-images.githubusercontent.com/43141830/403392148-7c6a89e9-d151-44e8-85cc-7b708c619b17.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2MTQ2NjAsIm5iZiI6MTczOTYxNDM2MCwicGF0aCI6Ii80MzE0MTgzMC80MDMzOTIxNDgtN2M2YTg5ZTktZDE1MS00NGU4LTg1Y2MtN2I3MDhjNjE5YjE3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDEwMTI0MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTYwNWZjZmQ3YTVhZDFiZThhMjg1Y2Q4MTg2NTMxMjRjODczODI1NWZjNzMzOWE4YTZhYTNiODNjODljNmE2M2QmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.LH4k8pFCOu9gf8mUOfhl7-Wt_z3Rr4i2VdMNIsNet7c)
After
![EJBCA_Admin-GUI_Signing-algorithm_2-AFTER](https://private-user-images.githubusercontent.com/43141830/403392209-a3aed739-0bd2-43f4-9f07-932ff5182410.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2MTQ2NjAsIm5iZiI6MTczOTYxNDM2MCwicGF0aCI6Ii80MzE0MTgzMC80MDMzOTIyMDktYTNhZWQ3MzktMGJkMi00M2Y0LTlmMDctOTMyZmY1MTgyNDEwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDEwMTI0MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNmZTVlN2Y5MGIyMzRhNWRkYWIzNWE2NDA5MmJjZDU2YzRiZmE3MTRmOWUzNzFmZDdkZjhiMDdhY2Q2NjRlNzgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.LYys2NafnNds1hIQhjLXVrXkv5dlzg_Wpuxzvl74PUE)
How has this been tested?
Tested in Web GUI.
Checklist before the review request