Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

role domain fix, cleanup #31

Merged
merged 3 commits into from
Apr 18, 2024
Merged

role domain fix, cleanup #31

merged 3 commits into from
Apr 18, 2024

Conversation

joevanwanzeeleKF
Copy link
Contributor

  • Fixed error that prevented enforcement of role domain policy
  • Removed deprecated artifacts
  • Cleaned up formatting and updated README to describe how roles are used.

joevanwanzeeleKF and others added 2 commits April 1, 2024 13:16
@joevanwanzeeleKF @spbsoluble
Role domain validation (#30)
b2e0a4d 
Co-authored-by: sbailey <[email protected]>
Co-authored-by: Keyfactor <[email protected]>
@joevanwanzeeleKF
SANS validation
3c54777 
- Updated SANs validation
- Included validation to check SAN exists in CN.
JDKeyfactor
JDKeyfactor approved these changes Apr 3, 2024
View reviewed changes
Copy link

@JDKeyfactor JDKeyfactor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic looks good. Can we run some tests and verify that if AllowSubdomains is false, you're no longer allowed to request any arbitrary DNS SANs unrelated to the target domain?

@joevanwanzeeleKF
Copy link
Contributor Author

This logic looks good. Can we run some tests and verify that if AllowSubdomains is false, you're no longer allowed to request any arbitrary DNS SANs unrelated to the target domain?

I have tested it, but it could be worth someone else trying it out. Adding Mark T to reviewers.

@joevanwanzeeleKF @spbsoluble
Fixed date format in revocation request (#33)
63d688e 
Co-authored-by: sbailey <[email protected]>
Co-authored-by: Keyfactor <[email protected]>
fiddlermikey
fiddlermikey approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@fiddlermikey fiddlermikey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rc.32 approved by FM

@fiddlermikey fiddlermikey merged commit 8b50004 into release-1.3 Apr 18, 2024
28 checks passed
@fiddlermikey fiddlermikey deleted the checksum-build-action branch April 18, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fiddlermikey fiddlermikey fiddlermikey approved these changes

@JDKeyfactor JDKeyfactor JDKeyfactor approved these changes

@markthwaiteskeyfactor markthwaiteskeyfactor Awaiting requested review from markthwaiteskeyfactor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joevanwanzeeleKF @fiddlermikey @JDKeyfactor