Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOD/#78] splash / Splash 화면 앱 호환성 대응 및 다크모드 비활성화 #80

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[MOD/#78] splash / Splash 화면 앱 호환성 대응 및 다크모드 비활성화 #80

wants to merge 2 commits into from

Conversation

b1urrrr
Copy link
Member

@b1urrrr b1urrrr commented Mar 9, 2023

관련 이슈

작업 내역

  • Splash 화면 앱 호환성 대응
  • 다크모드 비활성화

PR 포인트

  • API 31버전 이상의 기기에서 아직 테스트를 해보지 못했는데 테스트 해줄 수 있으신 분 계신가요?

실행 화면

Android.Emulator.-.Galaxy_S21_API_28_5554.2023-03-09.13-26-50.mp4

@b1urrrr b1urrrr added FIX 🔨 버그 및 오류 해결 MOD ✅ 코드 수정 및 내부 파일 수정 채연 🐸 채연's task labels Mar 9, 2023
@b1urrrr b1urrrr added this to the Refactoring milestone Mar 9, 2023
@b1urrrr b1urrrr requested a review from a team March 9, 2023 04:29
@b1urrrr b1urrrr self-assigned this Mar 9, 2023
@b1urrrr b1urrrr changed the title [MOD/#78] Splash 화면 앱 호환성 대응 및 다크모드 비활성화 [MOD/#78] splash / Splash 화면 앱 호환성 대응 및 다크모드 비활성화 Mar 9, 2023
0zlrlo
0zlrlo approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@0zlrlo 0zlrlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

옹 고생하셨습니다! 안드로이드 폰이 없어서 테스트는 못하네요ㅠㅠ

@b1urrrr b1urrrr requested a review from etama123 March 11, 2023 18:35
etama123
etama123 approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@etama123 etama123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드 확인했습니다!!
S22+ 에서 확인했을 때 스플래시 화면이 안떠서 이 부분 다시 한 번 확인 부탁드려요
고생하셨습니다❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0zlrlo 0zlrlo 0zlrlo approved these changes

@etama123 etama123 etama123 approved these changes

Assignees

@b1urrrr b1urrrr

Labels
FIX 🔨 버그 및 오류 해결 MOD ✅ 코드 수정 및 내부 파일 수정 채연 🐸 채연's task
Projects
Keyneez Android 💚
Status: In Progress
Milestone
Refactoring
Development

Successfully merging this pull request may close these issues.

[MOD] splash / 31 이후 버전 앱 호환성 대응
3 participants
@b1urrrr @etama123 @0zlrlo