Migrate to latest revision of Zcash crates #1618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuttycom
approved these changes
Feb 21, 2025
daira
reviewed
Feb 21, 2025
Comment on lines
+580
to
+582
| version = "0.6.0-pre.1" | ||
| source = "registry+https://github.com/rust-lang/crates.io-index" | ||
| checksum = "143f5327f23168716be068f8e1014ba2ea16a6c91e8777bc8927da7b51e1df1f" |
There was a problem hiding this comment.
Reviewed KeystoneHQ/crates@main...iqlusioninc:crates:bip32/v0.6.0-pre.1 which is a fast-forward. Looks to be mostly dependency updates, other changes are trivial. Rust MSRV is bumped to 1.81.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
When the Zcash app was added, some modifications to the upstream Zcash Rust crates were needed to enable no-std support. At the time, these changes were blocked on third-party dependency updates, and so the Keystone firmware depended on patched branches. Now, we have crate releases that include the necessary no-std support, so the Keystone firmware can depend on them directly.
Pre-merge check list
How to test
Build whichever firmware versions contain the Zcash app.