-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zstd compression #324
base: master
Are you sure you want to change the base?
Zstd compression #324
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just seems that the newly written files will be possible to open with new versions of keyvi only ... don't remember do we have some sort of min version requirement somewhere in code ?
Good point! Yes, we have versioning in keyvi files. I will make use of it. It should be possible to only bump the version if Currently an old version would throw an exception the 1st time a value has to be unpacked. With versioning in place it will not be possible to open a dictionary that uses |
dd3c595
to
fbc86d1
Compare
added versioning,
|
add zstd compression support