Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for true edits and deletes through webhooks #19

Open
wants to merge 18 commits into
base: dev
Choose a base branch
from

Conversation

Cubox
Copy link

@Cubox Cubox commented Nov 12, 2020

As I'm pushing my whole set of edits, I am aware that you might not want to just merge everything at once, but you can use my code to integrate into yours.

You will need eris and add this PR to the code abalabahaha/eris#1060

@Khaaz
Copy link
Owner

Khaaz commented Dec 4, 2020

I realised I haven't answered here, sorry.
I will have a closer look when implementing that feature. It's still not officially live in eris iirc.
I got very busy and this is unfortunately not my top priority so it will have to wait a bit, but it's coming for sure.
Thanks for the work you've done here 👍

related issue #16

@X-Niter
Copy link

X-Niter commented Jan 2, 2021

So I just got done running this pr and such, and besides a few cosmetic things I personally wanted to tweak for on my end, everything has worked out with out an issue.
May not be of any importance, but I thought I'd give the positive remarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants