[SR] Add comment about creating translation tickets #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a comment to the `strings.ts` file so it's easy to keep track of which strings will need to be finalized before translation tickets are made. We want to wait until all the interactive element strings for interactive graph have been written and confirmed before creating their respective translation tickets. Issue: https://khanacademy.atlassian.net/browse/LEMS-2660 Test plan: N/A
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (c29535a) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1894If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1894 |
|
Size Change: +110 B (+0.01%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
nishasy
commented
Nov 21, 2024
Merged
nishasy
added a commit
that referenced
this pull request
Nov 26, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Patch Changes - [#1896](#1896) [`56fd44806`](56fd448) Thanks [@catandthemachines](https://github.com/catandthemachines)! - Fixing intersecting polygon sides issues for unlimited sided polygon. - [#1894](#1894) [`01edfb8be`](01edfb8) Thanks [@nishasy](https://github.com/nishasy)! - [SR] Add comment about making translation tickets - [#1875](#1875) [`28cae9d2a`](28cae9d) Thanks [@nishasy](https://github.com/nishasy)! - [Locked Labels] Count lone unescaped \\$ as regular dollar signs in TeX ## @khanacademy/[email protected] ### Patch Changes - [#1874](#1874) [`42d25c2d2`](42d25c2) Thanks [@nishasy](https://github.com/nishasy)! - [Locked Figure Aria] Fix \\$ edge cases for spoken math aria labels - [#1912](#1912) [`44e78a95d`](44e78a9) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph Editor] Stop cursor jumps in number input fields - [#1875](#1875) [`28cae9d2a`](28cae9d) Thanks [@nishasy](https://github.com/nishasy)! - [Locked Labels] Count lone unescaped \\$ as regular dollar signs in TeX - Updated dependencies \[[`56fd44806`](56fd448), [`01edfb8be`](01edfb8), [`28cae9d2a`](28cae9d)]: - @khanacademy/[email protected]
benchristel
pushed a commit
that referenced
this pull request
Nov 26, 2024
## Summary: Add a comment to the `strings.ts` file so it's easy to keep track of which strings will need to be finalized before translation tickets are made. We want to wait until all the interactive element strings for interactive graph have been written and confirmed before creating their respective translation tickets. Issue: https://khanacademy.atlassian.net/browse/LEMS-2660 ## Test plan: N/A Author: nishasy Reviewers: nishasy, catandthemachines, benchristel, anakaren-rojas Required Reviewers: Approved By: catandthemachines, benchristel Checks: ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x), ✅ gerald Pull Request URL: #1894
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add a comment to the
strings.tsfile so it's easyto keep track of which strings will need to be
finalized before translation tickets are made.
We want to wait until all the interactive element
strings for interactive graph have been written
and confirmed before creating their respective
translation tickets.
Issue: https://khanacademy.atlassian.net/browse/LEMS-2660
Test plan:
N/A