Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Interactive Graph Editor] Stop cursor jumps in number input fields #1912

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

nishasy
Copy link
Contributor

@nishasy nishasy commented Nov 25, 2024

Summary:

In order to stop cursor jumps in number fields, up I'm updating the ScrolllessNumberTextField
component to have part of the implementation of EditableControlledInput, which makes sure that
the input stays consistent until blurred.

Issue: https://khanacademy.atlassian.net/browse/LEMS-2303

Test plan:

Before and after demos

Before

Screen.Recording.2024-11-25.at.4.31.12.PM.mov

After

Screen.Recording.2024-11-25.at.4.31.55.PM.mov

@nishasy nishasy self-assigned this Nov 25, 2024
Copy link
Contributor

github-actions bot commented Nov 25, 2024

Size Change: +381 B (+0.03%)

Total Size: 1.29 MB

Filename Size Change
packages/perseus-editor/dist/es/index.js 698 kB +381 B (+0.05%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 39 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 77.9 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus/dist/es/index.js 421 kB
packages/perseus/dist/es/strings.js 3.57 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.5 kB

compressed-size-action

@nishasy nishasy changed the title Use EditableControlledInput body within ScrolllessNumberTextField [Interactive Graph Editor] Stop cursor jumps in number input fields Nov 25, 2024
Copy link
Contributor

github-actions bot commented Nov 25, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (5438c5c) and published it to npm. You
can install it using the tag PR1912.

Example:

yarn add @khanacademy/perseus@PR1912

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1912

@nishasy nishasy marked this pull request as ready for review November 26, 2024 00:32
@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/neat-kiwis-relax.md, packages/perseus-editor/src/components/scrollless-number-text-field.tsx, packages/perseus-editor/src/widgets/interactive-graph-editor/locked-figures/locked-point-settings.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants