OpenXR android bump versions #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
reviewed
Mar 13, 2024
Comment on lines
-40
to
+48
| # This must match android.compileSdk in all Android build.gradle files | ||
| ENV ANDROID_COMPILE_SDK=29 | ||
| # # This must match android.compileSdk in all Android build.gradle files | ||
| # ENV ANDROID_COMPILE_SDK=33 | ||
|
|
||
| # This must match android.buildToolsVersion in all Android build.gradle files | ||
| ENV ANDROID_BUILD_TOOLS=30.0.3 | ||
| # # This must match android.buildToolsVersion in all Android build.gradle files | ||
| # ENV ANDROID_BUILD_TOOLS=34.0.0 | ||
|
|
||
| # look up on https://developer.android.com/studio/index.html#downloads when updating other versions | ||
| ENV ANDROID_CLI_TOOLS=9477386 | ||
| # # look up on https://developer.android.com/studio/index.html#downloads when updating other versions | ||
| # ENV ANDROID_CLI_TOOLS=10406996 |
There was a problem hiding this comment.
Maybe delete all this when it doesn't need to be set?
There was a problem hiding this comment.
yeah I debated on this one. This is semi-generated from a script in the Monado repo, which uses the same basic outline, which is why I left it.
oddhack
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading versions of Android tools.
Also improving the scripts to make them easier to use, just a little.
I've already pushed this image.