OpenCL C: Update ULP requirements for half-precision divide #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rocal Update ULP requirements for these builtins to 1.0 as per discussion on KhronosGroup#1278
bashbaug
reviewed
Jan 7, 2025
There was a problem hiding this comment.
Can you please update the SPIR-V environment spec also?
OpenCL-Docs/env/numerical_compliance.asciidoc
Lines 196 to 199 in 0f4b9a6
Note, there is no specific SPIR-V instruction for reciprocal, so only divide needs to be updated.
If we decide to restrict this relaxation to just divide, and not to reciprocal also, then we will need to rethink what we document in the SPIR-V environment spec.
kpet
changed the title
bashbaug
approved these changes
Jan 14, 2025
bashbaug
reviewed
Jan 14, 2025
| @@ -16289,7 +16289,7 @@ is the infinitely precise result. | |||
| | *_x_ - _y_* | Correctly rounded | Correctly rounded | |||
| | *_x_ * _y_* | Correctly rounded | Correctly rounded | |||
| | *1.0 / _x_* | Correctly rounded | \<= 1 ulp | |||
There was a problem hiding this comment.
Discussed in the January 14th teleconference, and we decided to relax reciprocal (for now) as well.
Suggested change
| | *1.0 / _x_* | Correctly rounded | \<= 1 ulp | |
| | *1.0 / _x_* | \<= 1 ulp | \<= 1 ulp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ULP requirements for these builtins to 1.0 as per discussion on #1278