Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented Callback sample #87

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Implemented Callback sample #87

merged 3 commits into from
Dec 5, 2023

Conversation

mfep
Copy link
Contributor

@mfep mfep commented Oct 10, 2023

  • Implemented sample showcasing event-based synchronization of command queues and event callbacks,
  • for details, please visit the newly added README file.

@CLAassistant
Copy link

CLAassistant commented Oct 10, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

bashbaug
bashbaug reviewed Nov 14, 2023
View reviewed changes
Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM - this is a clever sample!

bashbaug
bashbaug reviewed Nov 16, 2023
View reviewed changes
Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think this is getting close. Please take a look at the one remaining comment above, and the naming comment below, otherwise all of my questions have been addressed.

@bashbaug
Copy link
Contributor

bashbaug commented Dec 5, 2023

Merging as discussed in the December 5th teleconference.

@bashbaug bashbaug merged commit cc5e561 into KhronosGroup:main Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashbaug bashbaug bashbaug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfep @CLAassistant @bashbaug