-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented multi-device sample #91
Conversation
87a4154
to
419fe40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I only reviewed the last commit in this PR.
11c0765
to
b818605
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting closer but a few issues remain, and there are a few new ones.
b818605
to
b33c0e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest version LGTM, at least the last two commits (the ones for the multi-device sample specifically). Thanks!
You may want to keep just those two commits in this PR because the other infrastructure-related commits are still under review.
b33c0e4
to
0babaf4
Compare
Rebased branch and removed unrelated commits. So I think this is ready to be merged :) |
Requested a review from @nikhiljnv, planning to merge tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except a minor comment to fix the limit for cl_device_partition_property.
0babaf4
to
b6475e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
Merging as agreed in the December 12th teleconference. |
This PR adds the C/C++ samples showcasing a multi-device convolution computation that makes use of sub-devices and sub-buffers.
Note: only the last commit is relevant for the PR, all the other commits are from the StreamHPC:release-cd branch. After #88 is merged, this should be trivial to rebase/merge.