Implement SPV_INTEL_2d_block_io #2751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriPlyakhin
force-pushed
the
SPV_INTEL_2d_block_io
branch
from
980f06f to
68a4cfe
Compare
|
build failures are unrelated, restarting pre-commit with HEAD on top of #2753 |
YuriPlyakhin
force-pushed
the
SPV_INTEL_2d_block_io
branch
from
7b56852 to
f6e0e86
Compare
YuriPlyakhin
force-pushed
the
SPV_INTEL_2d_block_io
branch
from
f6e0e86 to
88794b6
Compare
MrSidims
reviewed
Jan 27, 2025
| ; __spirv_Subgroup2DBlockLoadTransformINTEL(i, i, i, i, base_address, width, height, pitch, coord, dst_pointer); | ||
| ; __spirv_Subgroup2DBlockLoadTransposeINTEL(i, i, i, i, base_address, width, height, pitch, coord, dst_pointer); | ||
| ; __spirv_Subgroup2DBlockPrefetchINTEL(i, i, i, i, base_address, width, height, pitch, coord); | ||
| ; __spirv_Subgroup2DBlockStoreINTEL(i, i, i, i, src_pointer, dst_base_pointer, width, height, pitch, coord); |
There was a problem hiding this comment.
note mangling is being changed from:
__spirv_Subgroup2DBlockStoreINTEL(int, int, int, int, void const*, void AS1*, int, int, int, int vector[2])
to:
__spirv_Subgroup2DBlockStoreINTEL(int, int, int, int, char*, char AS1*, int, int, int, int vector[2])
it should be fine and not related to the patch
MrSidims
approved these changes
Jan 27, 2025
YuriPlyakhin
added a commit
to YuriPlyakhin/SPIRV-LLVM-Translator
that referenced
this pull request
Jan 30, 2025
YuriPlyakhin
added a commit
to YuriPlyakhin/SPIRV-LLVM-Translator
that referenced
this pull request
Jan 30, 2025
YuriPlyakhin
added a commit
to YuriPlyakhin/SPIRV-LLVM-Translator
that referenced
this pull request
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec: https://github.khronos.org/SPIRV-Registry/extensions/INTEL/SPV_INTEL_2d_block_io.html