Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace SPV_INTEL_long_composites ext with the SPV_INTEL_long_composites #2968

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

vmaksimo
Copy link
Contributor

This continues #2258
All the backports with the rename has reached the backend drivers, so now it's safe to remove the old naming.

This continues KhronosGroup#2258
All the backports with the rename has reached the backend drivers, so
now it's safe to remove the old naming.
Copy link
Contributor

@MrSidims MrSidims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our E2E tests pass with this change, right?

@vmaksimo
Copy link
Contributor Author

Our E2E tests pass with this change, right?

@MrSidims looks so!

@MrSidims MrSidims merged commit ee6e8fa into KhronosGroup:main Jan 27, 2025
9 checks passed
@maksimsab
Copy link
Contributor

Hi @vmaksimo !

This change should be adopted in Clang Driver.

https://github.com/intel/llvm/blob/20d4bec7e6413c1f6350981e420931ea1b8457ea/clang/lib/Driver/ToolChains/Clang.cpp#L10790

Otherwise, it will start failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants