Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport to 14] Add return type for OpReadClockKHR SPIR-V friendly IR #2970

Merged
merged 1 commit into from
Jan 28, 2025
Merged

[Backport to 14] Add return type for OpReadClockKHR SPIR-V friendly IR #2970

merged 1 commit into from
Jan 28, 2025

Conversation

uditagarwal97
Copy link

OpReadClockKHR can return unsigned i64 or <2 x i32>. Include the return type in the SPIR-V friendly IR function name, to be able to distinguish between both versions.

Backport of #2562

@svenvh @uditagarwal97
Add return type for OpReadClockKHR SPIR-V friendly IR (KhronosGroup#2562
aa5face 
)

`OpReadClockKHR` can return unsigned `i64` or `<2 x i32>`.  Include
the return type in the SPIR-V friendly IR function name, to be able to
distinguish between both versions.
MrSidims
MrSidims approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@MrSidims MrSidims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM this and other backports

@uditagarwal97 uditagarwal97 marked this pull request as ready for review January 27, 2025 16:27
@uditagarwal97
Copy link
Author

uditagarwal97 commented Jan 27, 2025 •
edited
Loading

Hi @MrSidims,
Could you please merge this and other related backport PRs?

@svenvh svenvh merged commit 9df26b6 into KhronosGroup:llvm_release_140 Jan 28, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenvh svenvh svenvh approved these changes

@MrSidims MrSidims MrSidims approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uditagarwal97 @svenvh @MrSidims