Update for nocapture to captures(none) Attribute change #2980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This leaves two tests failing: Perhaps @vmaksimo or @MrSidims can followup with a PR to fix those? |
|
@svenvh sure, you may XFAIL the tests and we will handle it. Thanks! |
Update after llvm-project commit 29441e4f5fa5 ("[IR] Convert from
nocapture to captures(none) (#123181)", 2025-01-29).
This includes a bulk replacement `s/nocapture/captures(none)/g` in the
test files. A few of the `captures` attributes in CHECK lines had to
be reordered manually.
svenvh
force-pushed
the
nocaptures-change
branch
from
c6267bc to
0b7d957
Compare
MrSidims
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update after llvm-project commit llvm/llvm-project@29441e4f5fa5 ("[IR] Convert from nocapture to captures(none) (#123181)", 2025-01-29).
This includes a bulk replacement
s/nocapture/captures(none)/gin the test files. A few of thecapturesattributes in CHECK lines had to be reordered manually.