Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sycl_khr_free_function_commands extension #644

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
47863fa
Add sycl_khr_free_function_commands extension
Pennycook Oct 17, 2024
ebe4dc0
Merge branch 'main' into khr_free_function_commands
Pennycook Dec 2, 2024
ce08652
Reword khr_free_function_commands comment
Pennycook Dec 5, 2024
372bb3b
Add periods to khr_free_function_commands comments
Pennycook Dec 5, 2024
9747f7a
Add + marks to code blocks containing ...
Pennycook Dec 6, 2024
2527e90
Require at least 1 reduction in *_reduce functions
Pennycook Dec 6, 2024
f63adeb
Replace "must be" with "is" in constraints
Pennycook Dec 6, 2024
47c08f8
Use bulleted list for multiple constraints
Pennycook Dec 6, 2024
15fd80a
Rewrite preconditions for USM copy functions
Pennycook Dec 6, 2024
9c62792
Fix typo in non-normative note
Pennycook Dec 6, 2024
4377549
Define kernel object overloads via equivalence
Pennycook Dec 6, 2024
c24fb13
Clarify dependencies for command_/event_barrier
Pennycook Dec 6, 2024
664a912
Clarify that event_barrier can be a no-op
Pennycook Dec 6, 2024
16111b2
Add missing invocation constructor
Pennycook Dec 6, 2024
88b540a
Restart numbering at 1 in each synopsis block
Pennycook Dec 6, 2024
2575901
Replace backticks with [code] environment
Pennycook Dec 6, 2024
8fa1ce2
Add + marks to code blocks containing ... again
Pennycook Dec 6, 2024
8d79af4
Fix grammar: "is" to "are"
Pennycook Dec 6, 2024
2ba2394
Fix formatting of bulleted lists
Pennycook Dec 6, 2024
e382dbc
Fix more instances of "is" that should be "are"
Pennycook Dec 6, 2024
a9bdc10
Remove unnecessary device-copyable constraint
Pennycook Dec 6, 2024
269706c
Remove khr::invocation from free_function_commands
Pennycook Dec 6, 2024
fa8a8f6
Remove empty issues section
Pennycook Dec 9, 2024
db380b4
Add missing constraints to fill overloads
Pennycook Dec 9, 2024
d26831a
Remove *_reduce functions for kernel objects
Pennycook Dec 12, 2024
75867f7
Fix copy-paste error in launch_task definition
Pennycook Jan 17, 2025
151f632
Remove unnecessary "is"
Pennycook Jan 20, 2025
32d11f5
Explain potential performance overhead of events
Pennycook Jan 20, 2025
165d07e
Add no-op note to command_barrier
Pennycook Jan 20, 2025
be56bb7
Weaken note about no-op from "is" to "may be"
Pennycook Jan 20, 2025
9897e6d
Fix copy-paste error in khr::copy
Pennycook Jan 22, 2025
b756d9e
Change KHR names to lower case
Pennycook Jan 23, 2025
e68a7c0
Remove sycl:: in free-function-command synopses
Pennycook Jan 24, 2025
96c101e
Add missing require() calls from queue overloads
Pennycook Jan 24, 2025
b279f37
Fix alignment of overload numbers
Pennycook Jan 24, 2025
d7ce65f
Fix parameter pack syntax
Pennycook Jan 24, 2025
19440ec
Add missing ptr parameter to memset
Pennycook Jan 28, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add missing invocation constructor
  • Loading branch information
Pennycook committed Dec 6, 2024
commit 16111b2d8a9e5ccd685d61a905dce9f158d094e8
16 changes: 16 additions & 0 deletions adoc/extensions/sycl_khr_free_function_commands.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -904,6 +904,7 @@ class invocation
sub_group<Dimensions> get_sub_group() const noexcept;

// Available for backwards compatibility only.
invocation(nd_item<Dimensions> it) noexcept;
operator nd_item<Dimensions>() const noexcept;
};

Expand Down Expand Up @@ -961,6 +962,21 @@ invocation belongs.

'''

.[apidef]#invocation constructor#
[source,role=synopsis,id=api:khr-free-function-commands-invocation-invocation-constructor]
----
invocation(nd_item<Dimensions>() it) noexcept;
----

_Effects_: Constructs a [code]#invocation# representing the same work-item as
[code]#it#.

{note}This function exists only to provide backwards compatibility with SYCL
2020 code in order to facilitate experimentation with the new interface proposed
by this extension.{endnote}

'''

.[apidef]#nd_item conversion operator#
[source,role=synopsis,id=api:khr-free-function-commands-invocation-nd_item-conversion-operator]
----
Expand Down
Loading