Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add layer settings library #254

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Add layer settings library #254

merged 1 commit into from
Aug 29, 2023

Conversation

christophe-lunarg
Copy link
Contributor

No description provided.

@christophe-lunarg christophe-lunarg added the enhancement New feature or request label Jun 26, 2023
@christophe-lunarg christophe-lunarg self-assigned this Jun 26, 2023
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build queued with queue ID 853.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build queued with queue ID 859.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 548 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 548 passed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build queued with queue ID 925.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 549 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 549 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build queued with queue ID 967.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 550 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 550 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build queued with queue ID 1691.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 565 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 565 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build queued with queue ID 1709.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 566 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 566 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build queued with queue ID 1735.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 567 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 567 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 679 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 679 failed.

@juan-lunarg
Copy link
Contributor

LGTM but I want to make sure @juan-lunarg is good with the cmake parts, given that we had problems there when VVL did this change

CMake parts look fine.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build queued with queue ID 27241.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 680 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build queued with queue ID 27251.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 681 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 681 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build queued with queue ID 27278.

juan-lunarg
juan-lunarg suggested changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@juan-lunarg juan-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase on main. ndk-build removed from this repo.

juan-lunarg
juan-lunarg suggested changes Aug 28, 2023
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
build-android/known_good.json Outdated Show resolved Hide resolved
scripts/known_good.json Outdated Show resolved Hide resolved
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build queued with queue ID 32517.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build queued with queue ID 32526.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 696 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 696 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build queued with queue ID 32627.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 697 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 697 passed.

jeremyg-lunarg
jeremyg-lunarg approved these changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@jeremyg-lunarg jeremyg-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Juan's concern was addressed by rebasing, it looks like.

@juan-lunarg juan-lunarg merged commit 7ccfcb7 into main Aug 29, 2023
21 checks passed
@juan-lunarg juan-lunarg deleted the layer-settings-lib branch August 29, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juan-lunarg juan-lunarg juan-lunarg approved these changes

@jeremyg-lunarg jeremyg-lunarg jeremyg-lunarg approved these changes

@ziga-lunarg ziga-lunarg Awaiting requested review from ziga-lunarg

Assignees

@christophe-lunarg christophe-lunarg

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@christophe-lunarg @ci-tester-lunarg @juan-lunarg @jeremyg-lunarg