Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: Use common LunarG function for build config #316

Merged
merged 1 commit into from
Sep 13, 2023
Merged

cmake: Use common LunarG function for build config #316

merged 1 commit into from
Sep 13, 2023

Conversation

christophe-lunarg
Copy link
Contributor

@christophe-lunarg christophe-lunarg commented Sep 12, 2023 •
edited
Loading

A PR mainly also to try to understand the issue Jeremy experienced...

@christophe-lunarg christophe-lunarg self-assigned this Sep 12, 2023
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build queued with queue ID 40763.

@christophe-lunarg christophe-lunarg added the enhancement New feature or request label Sep 12, 2023
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 715 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 715 failed.

@juan-lunarg
Copy link
Contributor

A PR mainly also to try to understand the issue Jeremy experienced...

Jeremy was having issues due to the utility library exporting strict compiler warnings:
KhronosGroup/Vulkan-Utility-Libraries#103

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build queued with queue ID 40935.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 716 running.

@christophe-lunarg
Copy link
Contributor Author

A PR mainly also to try to understand the issue Jeremy experienced...

Jeremy was having issues due to the utility library exporting strict compiler warnings: KhronosGroup/Vulkan-Utility-Libraries#103

Yes, I am resolving the issues in the repository so that the inheritance of the Vulkan-Utility-Libraries build options don't cause issues anymore.

If that's a good plan with you.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build queued with queue ID 40954.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 717 running.

@juan-lunarg
Copy link
Contributor

If that's a good plan with you.

That's a good plan 👍🏾

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 717 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build queued with queue ID 40986.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 718 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 718 failed.

juan-lunarg
juan-lunarg reviewed Sep 12, 2023
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build queued with queue ID 41000.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 719 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 719 failed.

@jeremyg-lunarg
Copy link
Collaborator

Is this PR intended to be merged or just a test?

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build queued with queue ID 41162.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 720 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 720 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build queued with queue ID 41484.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 721 running.

@christophe-lunarg
Copy link
Contributor Author

Is this PR intended to be merged or just a test?

Yes this is intented to be merged.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 721 passed.

juan-lunarg
juan-lunarg approved these changes Sep 13, 2023
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build queued with queue ID 41719.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 722 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 722 passed.

@christophe-lunarg christophe-lunarg merged commit 13e3d99 into main Sep 13, 2023
21 checks passed
@christophe-lunarg christophe-lunarg deleted the cmake-lunarg-build-configs branch September 13, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juan-lunarg juan-lunarg juan-lunarg approved these changes

@jeremyg-lunarg jeremyg-lunarg Awaiting requested review from jeremyg-lunarg

Assignees

@christophe-lunarg christophe-lunarg

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@christophe-lunarg @ci-tester-lunarg @juan-lunarg @jeremyg-lunarg