Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMake syntax error #436

Closed
wants to merge 1 commit into from
Closed

Fix CMake syntax error #436

wants to merge 1 commit into from

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Oct 19, 2024

No description provided.

@ci-tester-lunarg
Copy link
Collaborator

Author dg0yt not on autobuild list. Waiting for curator authorization before starting CI build.

@CLAassistant
Copy link

CLAassistant commented Oct 19, 2024

CLA assistant check
All committers have signed the CLA.

@ci-tester-lunarg
Copy link
Collaborator

Author dg0yt not on autobuild list. Waiting for curator authorization before starting CI build.

@dg0yt
Copy link
Contributor Author

dg0yt commented Oct 19, 2024

Obviously, the guarded CMake code was never run in the past. Now it fails here:

pkg_check_modules(WAYlAND_CLIENT QUIET REQUIRED IMPORTED_TARGET wayland-client)

Apart from wayland-client being not found in CI, my eyes immediately spot a capitalization issue in WAYlAND_CLIENT.

@jeremyg-lunarg
Copy link
Collaborator

Thanks for the PR! I'm investigating why we don't have CI wayland support in this repo, we do in others...

@jeremyg-lunarg
Copy link
Collaborator

I included your commit in #437 Thanks again for reporting this.

@dg0yt dg0yt deleted the patch-1 branch October 22, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants